← Previous · All Episodes · Next →
Code Reviews: Giving and Receiving Feedback Episode 7

Code Reviews: Giving and Receiving Feedback

This episode is all about giving and receiving feedback via code reviews. Use some of these tips and tricks in your next code review.

· 36:27

Disclaimer: The episode on Creating Pull Requests got lost so Episode 6 ended up being our Build vs Buy episode. 

Upcoming Conferences Of Note
Other Tips for giving a nice PR review
Remember the person on the other end of your review is a human. As devs it’s easy to mix our identity with the code we write and any criticism of that code can be challenging to absorb.
  • Timeliness 
    • Respond quickly if you are a reviewer
    • This can be especially challenging when dealing with major differences in timezone
  • Checklists 
    • Does this code belong somewhere else?
    • Is this code tested?
    • Do I understand this code? 
      • PRs can be a way to do knowledge transfer to other folks on the team
    • Are there any glaring security concerns?
    • Should someone else also review this change?
    • What might go wrong when this is deployed? 
      • Is there observability in place?
      • Is there a large migration that needs special treatment?
  • Other things: 
    • I try to group all of my replies into one big response rather than lots of individual comments, that way the
Tools Mentioned

View episode transcript

Creators and Guests

CJ Avilla
CJ Avilla
Developer Advocate @StripeDev. Veteran. 📽 https://t.co/2UI0oEAnFK. Building with Ruby, Rails, JavaScript
Colin Loretz
Colin Loretz
I like to build software and communities. Building software at @orbitmodel 🪐 Coworking at @renocollective 🎙Sharing software learnings on @buildandlearn_


Listen to Build and Learn using one of many popular podcasting apps or directories.

Apple Podcasts Spotify Overcast Pocket Casts Amazon Music
← Previous · All Episodes · Next →